Change node.save argument type to array

This is a support request not a bug.

I am getting the same error for node.save using a similar string (below)

{"type":"rundata","uid":"1","title":"TITLE","body":"BODY","field_html_song_list":[{"value":"Song","format":"2"}]}

Cannot use object of type stdClass as array in modules/cck/modules/text/text.module on line 439

sorry, think i flicked the priority somehow.

This is indeed a bug. The node resource is defined as a struct - but since it calls drupal_execute() all values sent to it should be arrays. Both the browser in Services itself and the JSON server decodes JSON into objects instead of into associative arrays.

Some services does some internal type casting to get around this but none of that casting is recursive so specifying an associative array as the value of a cck field will fail - since the cck field's form handler expects an array.

I would suggest that we remove the type 'struct' from Services 3.x and disallows objects in arguments - all complex values that Services will need to handle can be expressed as arrays. Would there be any drawbacks for doing this?

The fix for Services 2.2 would be to change the type of the node.save argument to be 'array'. Patch is attached for that.

A patch has also been sent to the JSON server: #952344: Check if argument is struct or array and parse differently

Maybe you meant to set this to dev so the patch works?

#11: 945788_change_nodesave_arg_to_array.patch queued for re-testing.

Um - how is it possible for such a small patch to fail? Can you try manually kylebrowning?

Re-rolled patch.

This is an API change, won't it break any existing installs?

Can't comment on json but xmlrpc casts objects to arrays so xmlrpc has always been sending an array in effect anyway. So any xmlrpc code will still run as expected, other servers ???

@heyrocker: The function accepting the argument hasn't changed and the argument types aren't enforced in any way.

The fact that argument types aren't enforced is the reason how this can have slipped through. The values sent to drupal_execute() emulates $_POST and $_POST is an array - not a struct.

JSON server doesn't check the type and has parsed everything as a struct - in #952344: Check if argument is struct or array and parse differently it will be changed.

The only place I know that actually checks the argument type is Services' own browser - and as reported in this and other issues it currently fails on CCK-data.

So: If any API-change has occurred then that has already been made, but it forgot to change the argument type.

And since, as marcingy notes, many servers actually doesn't differentiate between struct and array I really think that we should remove struct in favour of array: #954964: Remove argument type 'struct' in favor of 'array'

Seems like also neither the REST Server or the JSONRPC Server checks whether an argument is a struct or an array - they both always parse JSON as arrays.

Given voxpelli comments I'm happy to mark this rbtc as it sounds like no server is affected by the change as they already treat things as arrays anyway.

This has been commited to 2.x-dev

Hi
This is poll type
-> how to update this node in services

[choice] => Array
(
[0] => Array
(
[chtext] => Football
[chvotes] => 2
[chorder] => 0
)
}

I want to update => [choice] [0] [chvotes] ;

@mayurpimple: Open new issues - don't hijack old closed issues

sub